search

martin-stone / hsv-alpha-color-picker-android

A color picker and a color preference for use in Android applications.
Apache License 2.0
290 stars 60 forks source link

Delay and out of view in landscape #39

Closed kaushalkumar86 closed 6 years ago

kaushalkumar86 commented 6 years ago

First of all, thanks for the project. I am using your project library in my app. There is a delay in opening the picker view after tapping ( I am using your colorpicker in alertdialog). In Alertdialog, I have managed to change its layout from portrait to landscape without destroying the activity (via dialog dismiss and re create), but the view in landscape (whether its created for the 1st time or recreated) goes out of view at bottom. Only the view of main color arc selector goes out a few dps, rest alpha selector and sat selector are fine. I can send you a snapshot if it helps you.

kaushalkumar86 commented 6 years ago

I tested it more, the issue happens when I use the Alertdialog with Title. Otherwise its ok when used without title.

martin-stone commented 6 years ago

Glad you found a workaround for the landscape layout. Assuming you're OK without a title, I'm going to close this as a duplicate of #38.

kaushalkumar86 commented 6 years ago

Thanks for replying,

For now I am ok without title, but please lemme know if you fix it in upcoming updates.

KKA +918083562177

On Dec 6, 2017 6:59 PM, "Martin Stone" notifications@github.com wrote:

Glad you found a workaround for the landscape layout. Assuming you're OK without a title, I'm going to close this as a duplicate of #38 https://github.com/martin-stone/hsv-alpha-color-picker-android/issues/38 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/martin-stone/hsv-alpha-color-picker-android/issues/39#issuecomment-349639694, or mute the thread https://github.com/notifications/unsubscribe-auth/AE2gd_gzBiNkybNOqByJ2E6uZ3u89ejhks5s9paigaJpZM4Q3txr .

kaushalkumar86 commented 6 years ago

Thanks, delay is solved in this new update.