search

martin-stone / hsv-alpha-color-picker-android

A color picker and a color preference for use in Android applications.
Apache License 2.0
290 stars 60 forks source link

public constructor for ObservableColor #48

Closed fazjaxton closed 5 years ago

fazjaxton commented 5 years ago

I am trying to use the individual views directly in my own custom layout. However, I am unable to make an ObservableColor to link them together because the constructor is package-private. ("cannot be accessed from outside package") Could the constructor be made public for this use-case?

martin-stone commented 5 years ago

Done (version 2.4.2). I think the package scope was just an oversight.

It might make more sense for your use case to have a way of specifying a custom layout within the ColorPickerView. Then you wouldn't need to duplicate its functionality. E.g. If the view already had children it wouldn't inflate the R.layout.picker. More work though.

fazjaxton commented 5 years ago

Wow, thanks! Agreed that a way to customize ColorPickerView would be ideal. I'll use them as components for now.