search

martin-stone / hsv-alpha-color-picker-android

A color picker and a color preference for use in Android applications.
Apache License 2.0
290 stars 60 forks source link

jcenter() #58

Closed vulterey closed 2 years ago

vulterey commented 3 years ago

Hi Martin,

Is there any chance you will migrate repository from jcenter to mavenCentral soon?

Kind Regards Adam

martin-stone commented 3 years ago

Hi. Yes, that's the plan. I now have a sonatype account, but haven't had time to update the publish script.

vulterey commented 3 years ago

Hi Martin,

Thank you for your prompt answer. Let me know when you do it, please.

Regards

Adam

BTW: Random question. Where or in which app/software you created your avatar? It looks really well made.

martin-stone commented 3 years ago

It's stolen from some game art -- so would have been hand made by somebody with some artistic talent :-)

vulterey commented 3 years ago

Well, it is very persuading. I pictured you exactly like on this avatar ;) Thank you for your reply.

martin-stone commented 3 years ago

Let's leave this issue open, to reflect the status of the task.

martin-stone commented 3 years ago

Hi @vulterey. I've looked into Maven Central publishing and it involves a whole new set of dependencies that I'd rather not get entangled with, however JitPack seems to "just work". Could that be a solution for you? It's just a couple of changes to your build.gradle, documented in the updated Readme. Can you try it and confirm that it works for you? (It works effortlessly for me on my dependent project.)

vulterey commented 3 years ago

Got it right ;D

Steps:

In your gradle file:

  1. Remove from the dependencies section the line (if exists): implementation 'com.rarepebble:colorpicker:3.0.1'

  2. Remove from the repositories section the line (if exists): jcenter()

  3. Add to the dependencies section the line: implementation 'com.github.martin-stone:hsv-alpha-color-picker-android:3.0.1'

  4. Add to the repositories section the line: maven { url "https://jitpack.io" }

Example of the part of the gradle file:

... repositories { google() maven { url "https://jitpack.io" } }

dependencies { implementation 'com.github.martin-stone:hsv-alpha-color-picker-android:3.0.1' implementation fileTree(dir: 'libs', include: ['*.jar']) ...

I hope it will help others ;)

martin-stone commented 3 years ago

Glad you got it working. I'll update the readme with instructions to replace the old com.rarepebble:colorpicker line (I'd been writing it from the perspective of a new user of the library.)

vulterey commented 3 years ago

Yes, it took me a while, but finally, I nailed it. Thank you very much for your quick help.

ckhmer1 commented 3 years ago

Hello, could You please upload also version 2 to mavenCentral? I prefer it because it has fewer dependencies from the google libraries, and I don't use the androidx library to save space in my utility to be as small as possible.

Thanks Claudio

martin-stone commented 3 years ago

Hi @ckhmer1. Version 2 should also be usable via jitpack, as above. Have you tried it? (Pick any version number from the releases list.

ckhmer1 commented 3 years ago

Hi, I'm sorry, I didn't try yet. I thought that the version 2 was not maintained anymore, i like It because it is quite smaller than the version 3, because doesn't depend by Android X.

Thanks again Claudio