search

martin-stone / hsv-alpha-color-picker-android

A color picker and a color preference for use in Android applications.
Apache License 2.0
290 stars 60 forks source link

Colors not displaying properly with darkmode #60

Open RubenXos opened 2 years ago

RubenXos commented 2 years ago

Hi,

I just realized some colors (yellow and green shades) don't display properly when the device is on dark mode. I was going crazy with this, running my project on my phone with dark mode activated, until I ran it on an emulator that is by default in light mode. On the screenshot you can see that the selected color is yellow and it is displaying black. I guess this is not solvable because it is related with how android manages dark mode, and you have nothing to do there, but I wanted to inform of this.

Screenshot

martin-stone commented 2 years ago

Thanks for the report. I don't see this on the devices and emulators that I have currently to hand. Can you let me know what devices and OS versions you've seen this on?

It would be interesting to see what happens if the colour is transparent -- Does the background square pattern render correctly?

RubenXos commented 2 years ago

I've only seen this on my physical phone, which is a Xiaomi redmi note 9S with Android 10. I've only tried it with my phone and an emulator of Pixel 2 running Android 11, so I don't really know if its a problem of a specific version of Android, Xiaomi, or just my device (that last thing would be weird).

I'll do some testing and extend the report.