martin-ueding / thinkpad-scripts

Screen rotation, docking and other scripts for ThinkPad® X220 and X230 Tablet
Other
133 stars 23 forks source link

How do you uninstall this? #153

Closed NovaViper closed 4 years ago

NovaViper commented 4 years ago

Hi,I want to uninstall the scripts I used the Build manually instructions to install the scripts onto my Thinkpad L390 Yoga but soon discovered that it doesn't support auto rotate for my machine. Now I'm trying to uninstall it but can't seem to find anything in the docs documenting how to do so

martin-ueding commented 4 years ago

If you would like, you could check the ACPI hooks in the documentation to see whether we could add support for your device.

Otherwise you could try pip uninstall thinkpad-scripts. There will be some more files like the hooks that are not taken care of. There is no real uninstall way. The packages do that, but I don't have time to take care of them. So unfortunately it is not that satisfying at the moment.

jturner314 commented 4 years ago

This is a list of the files in the Arch Linux package. Note that the files may be in slightly different locations (e.g. /lib instead of /usr/lib) when following the build manually instructions.

  1. files starting with thinkpad in /etc/acpi/events (see these lines)
  2. files starting with thinkpad in /usr/bin (see these lines)
  3. directory /usr/lib/python3.8/site-packages/thinkpad_scripts-4.11.0-py3.8.egg-info
  4. directory /usr/lib/python3.8/site-packages/tps
  5. file /usr/lib/udev/hwdb.d/90-X2x0T-keyboard.hwdb
  6. file /usr/lib/udev/rules.d/81-thinkpad-dock.rules
  7. files starting with thinkpad in /usr/share/applications (see the list here)
  8. files starting with thinkpad in /usr/share/man/man1

I would assume that pip uninstall thinkpad-scripts would remove items 2, 3 and 4. You can remove the other files manually. Then, run udevadm hwdb --update and either reboot your computer or run udevadm trigger --action=change and restart acpid.

Edit: Fwiw, before uninstalling, I second @martin-ueding's suggestion of checking to see if your device has ACPI events that would be sufficient to add support for it. To do so, see this page in the docs.

NovaViper commented 4 years ago

@martin-ueding I did try to see if it supports the events, and it does somewhat work but I can't get complete rotation control (basically it rotates to whatever orientation I have the laptop). It does rotate but it just rotates upside down when I hold the laptop vertically

martin-ueding commented 4 years ago

So it rotates according to the physical orientation with a gravity sensor? As far as I know the thinkpad-scripts do not support that. If you have gravity rotation like on a mobile device, something else is at work with your laptop.

NovaViper commented 4 years ago

It seems to be some sort of gravity sensor, as I remember I did have a program on Kubuntu that allowed for the screen to rotate based on the orientation (Say if I had it rotated to where the charger port is at the top, then the screen would rotate to accommodate that, and the same instance if the charger port was rotated to face down and if I had the screen flipped horizontally (in tablet mode). However I can't seem to find that program anymore and the only things I've found closest to it is only on Arch Linux .

martin-ueding commented 4 years ago

I recall that Ubuntu Unity had some rotation at some point and that did interfere with our scripts as it somehow used two different properties (like transformation matrix vs. named orientation). I would think that we have a similar case here and that we flip the screen and then your program also flips it, effectively giving you the wrong thing.

In that case you either uninstall the thinkpad-scripts or the other program, or we try to work together with that program if it makes sense.

NovaViper commented 4 years ago

The thing I noticed with your script was that it did rotate, but it just seemed to be kinda stuck in a particular orientation. So like, if I flipped it to where the charger was on top, it would instead be flipped opposite to that direction (hence making the UI upside down) however if I had it at the bottom then it would be rightside-up. It seemed like the script has a particular orientation setting instead of an adaptive one

NovaViper commented 4 years ago

I still can't figure out how to install the scripts.. because all the ones i found that are seemingly made for the L390 Yoga are only on Arch Linux (in fact that's even where I found this script originally: https://wiki.archlinux.org/index.php/Tablet_PC#Automatic_rotation)

martin-ueding commented 4 years ago

The thinkpad-scripts do nothing with gravity, they use a fixed rotation. Mostly because my X220 does not have a gravity sensor anyway. On my laptop I honestly prefer that because I often adjust how I hold it and I don't want all my windows to get messed up. This is a shortcoming of the window manager and X-server, but I would not want that feature even if it existed.

NovaViper commented 4 years ago

Ah ok. I found a couple of modules but I have no clue how to install them on KDE neon

https://wiki.archlinux.org/index.php/Tablet_PC#Automatic_rotation

NovaViper commented 4 years ago

Hey guys! I'm closing this issue as I figured out how to get the scripts mentioned in the Arch linux wiki working! I went and switched over from Kubuntu to Manjaro KDE and the scripts mentioned worked perfectly. :)