Consider switching to a regularly maintained sprintf package

martinandert / counterpart

A translation and localization library for Node.js and the browser.

MIT License

242 stars 25 forks source link

Consider switching to a regularly maintained sprintf package #25

Closed Temaruk closed 9 years ago

Temaruk commented 9 years ago

Thank you for your time and effort in creating this awesome package!

It occurred to me that switching to https://github.com/alexei/sprintf.js might be as simple as 2 line changes. This is the lib on which the currently used (https://github.com/maritz/node-sprintf) is based (as mentioned in its docs).

One benefit I can see over the old one (there might be many more) is that interpolations would support computed values (functions). Would have been really useful for me. :)

martinandert commented 9 years ago

@Temaruk, do you mind creating a pull request? I'm currently really busy doing other things...

Temaruk commented 9 years ago

@martinandert I have created a PR as you requested, please check!