search

martinandert / react-translate-component

A component for React that utilizes the Counterpart module to provide multi-lingual/localized text content.
MIT License
322 stars 31 forks source link

Bumped peer dependency of counterpart #34

Closed rvdkooy closed 6 years ago

rvdkooy commented 6 years ago

When using counterpart 0.18.x and react-translate-component you will run into problems because both counterpart 0.18.x and 0.17.x will be downloaded when installing npm packages.

react-translate-component will then use version 0.17.x internally (in its own node_modules) and all resources are registered through version 0.18.x, which will result in "missing translation" errors

this bump for counterpart should fix the problem

rvdkooy commented 6 years ago

Actually.. We were using Yarn 0.24 and this version does not respect the caret (^0.17) being used in the peer dependencies. When I upgrade Yarn to the latest version it works fine.

So I actually don't think you need this PR :-)

btw: I noticed a folder called V2 in your counterpart 0.18.2 published package. is this intented?

martinandert commented 6 years ago

I noticed a folder called V2 in your counterpart 0.18.2 published package. is this intented?

No it's not ;) Thanks for reporting it. It got removed in v0.18.3..

rvdkooy commented 6 years ago

great!