search

martinandrovich / rb-pro5

The project combines the fields of robotic path planning, computer vision and artificial intelligence, to be implemented as algorithms with the purpose of controlling a robot within a simulated environment.
3 stars 0 forks source link

Rename of vel_t members. #4

Closed Slaxzer96 closed 4 years ago

Slaxzer96 commented 4 years ago

The current name of the members are confusing.

Slaxzer96 commented 4 years ago

done with renaming.

martinandrovich commented 4 years ago

done with renaming.

Please specify what the members have been renamed to.

martinandrovich commented 4 years ago

Just checked the file; are .speed and .dir sufficiently descriptive? Or should be try something like:

.delta_dir and .delta_ang or .dir_vel and .rot_vel?

Slaxzer96 commented 4 years ago

How about; Velocity and angular_velocity.

martinandrovich commented 4 years ago

How about; Velocity and angular_velocity.

Well, technically they're both one-dimensional quantities, being it's a translational_delta and rotational_delta, right?

martinandrovich commented 4 years ago

How about: a) .fwd_vel and .ang_vel b) vel_t::translational and vel_t::rotational?

or maybe abbreviate b?

Slaxzer96 commented 4 years ago

Huy. .velocity and .ang_vel This issue is closed.

martinandrovich commented 4 years ago

Since the velocity type already specifies that it contains information about velocities, it would make sense to specify which types of velocities, i.e. vel_t::trans and vel_t::ang.

Also: Imgur

Slaxzer96 commented 4 years ago

ye lets go with those.