martinber / noaa-apt

NOAA APT weather satellite image decoder, for Linux, Windows, RPi 2+, OSX and Android+Termux
http://noaa-apt.mbernardi.com.ar
GNU General Public License v3.0
601 stars 55 forks source link

Fix missing output_tips for Resample and Timestamp modes #18

Closed arcdarcd closed 4 years ago

arcdarcd commented 4 years ago

Also, set expected filename extension to .png or .wav accordingly.

Not sure if using output_filename_extension for each mode is better than matching again on mode inside the closure (line 436), but I had to use the move keyword to take ownership of the environment, since neither of those values are available inside the closure.

Please let me know if there is a better way to set the recommended file extension.

martinber commented 4 years ago

Nice work! I forgot about these other two modes.

I think that you did the right thing with the output_filename_extension and the move keyword.

To be fair I'm still not entirely happy with the line wrapping but it is better than nothing. I've been looking a bit at adding ellipsis to a GtkLabel, for example see the GUI from the Darktable program:

image

But a separate GtkLabel for the filename would be necessary. I will look a bit more into it

martinber commented 4 years ago

Wanted to let you know that I changed how the tips work. Now there are separate GtkLabels for each tip. This allows to "ellipsize" long paths, and at the same time to show a tooltip:

image

Thank you again!

arcdarcd commented 4 years ago

Awesome! I noticed no filename checks are done for the timestamp mode. Is that on purpose?

martinber commented 4 years ago

Yes, there are three tips used on Decoding and Resample but I don't think they are relevant in the Timestamp mode:

arcdarcd commented 4 years ago

That makes sense, thanks for the explanation!