Closed arcdarcd closed 4 years ago
Nice work! I forgot about these other two modes.
I think that you did the right thing with the output_filename_extension
and the move
keyword.
To be fair I'm still not entirely happy with the line wrapping but it is better than nothing. I've been looking a bit at adding ellipsis to a GtkLabel, for example see the GUI from the Darktable program:
But a separate GtkLabel for the filename would be necessary. I will look a bit more into it
Wanted to let you know that I changed how the tips work. Now there are separate GtkLabels for each tip. This allows to "ellipsize" long paths, and at the same time to show a tooltip:
Thank you again!
Awesome! I noticed no filename checks are done for the timestamp
mode. Is that on purpose?
Yes, there are three tips used on Decoding and Resample but I don't think they are relevant in the Timestamp mode:
That makes sense, thanks for the explanation!
Also, set expected filename extension to .png or .wav accordingly.
Not sure if using
output_filename_extension
for each mode is better than matching again onmode
inside the closure (line 436), but I had to use themove
keyword to take ownership of the environment, since neither of those values are available inside the closure.Please let me know if there is a better way to set the recommended file extension.