Closed arcdarcd closed 4 years ago
Yes, you may be right. The syncing is made in decode.py:find_sync()
, and I never checked if the syncing was that precise because it was not needed at the time.
I'm going to fix it. Do you have precise numbers of the width of every part? Where did you read that it should be 39px? I'm measuring an image in GIMP and it makes sense but I wanted to be sure Nevermind, I found it
Also, I'm going to think about structuring the image data
I fixed it, I was wondering if this vertical gray line became wider after the fix, but it looks the same. I think I will leave it
Before:
After:
I've noticed that the width of the sync band on the final image is around ~2px less than expected (37px instead of 39px). This causes these 2 pixels to end up at the end of each row.
This causes the sync region to "bite into" the minute markers, which in turn overflows into the image data, which overflows into the telemetry data, and so on.
It looks like this:
I'm not sure if it's possible to improve accuracy during syncing, and there is a workaround in place when rotating images (as it's only noticeable there), but maybe there is an easy fix for it.