martincarrera / clash-royale-api

:crown: Clash Royale API that provides information about the game.
http://www.clashapi.xyz/
MIT License
353 stars 80 forks source link

Update API #42

Closed martincarrera closed 7 years ago

martincarrera commented 7 years ago

Update API to include the changes made with the March update.

MaherFa commented 7 years ago

I have extracted the game textures and have the latest card art, they're high quality border-less and without the elixir drop atm, I can provide them as they are or add borders and give you them as PNGs, are you interested?

here's a sample cr_72

after adding the border card

martincarrera commented 7 years ago

Of course! If you can, add the border, update the images in the images folder and submit a pull request. Thanks!

MaherFa commented 7 years ago

Do you care for the rarity glow (golden for rares and pink for epics)? like do you consider it a feature or is it not needed. and what about the elixer drop? atm I have all PNGs ready with borders and without the glow nor the elixir drop. imo I think they look cleaner like this but it's up to you.

also wanted to double check with you about the "idName" (image names) for the new cards, I used:

martincarrera commented 7 years ago

It is OK without the glow and the elixir drops, I am not sure how much effort should mean adding the glow and how it would look like. If you want, submit a pull request as you have it now and if you want to add the glow and submit a new pull request in the future, it's up to you.

The names are OK like that, thanks!

MaherFa commented 7 years ago

effort is not an issue, I want this to be perfect. the issue is about consistency... old images only had glow for rares and epics and mostly because they were taken from screenshots. if we want to add glow we would have to add transparent pixels to cards without glow (commons and legendaries) to preserve the unity of image sizes.

anyway I uploaded the files for now but rather work on the arenas. I also have them clean with pixel perfect edges including the new legendary arena.

most likely work on them tomorrow along with the new double-chest and the new league Icons

martincarrera commented 7 years ago

Update: @MaherFa here is the json of updated cards. As soon as I add the new chests and leagues information, it will be in production.

MaherFa commented 7 years ago

Thank you so much. I will work on chest images and submit them later. Do you prefer them opened or closed. I will be creating them out of the original mutipart animation sprites. So I can create whatever frame we want. Any preferance?

martincarrera commented 7 years ago

You are the expert here, just see which one looks better and go ahead with that one.

Thanks again for all your time!

martincarrera commented 7 years ago

API is now up to date. @MaherFa I will create a issue for you to update the chests images, is it OK?

MaherFa commented 7 years ago

No need, chests are ready