search

martincarrera / clash-royale-api

:crown: Clash Royale API that provides information about the game.
http://www.clashapi.xyz/
MIT License
354 stars 80 forks source link

Add card id #92

Closed lluisd closed 6 years ago

lluisd commented 7 years ago

Hi,

Can we add the card ids? like https://docs.google.com/spreadsheets/d/1hvoz1vYbK5-Wine0oRnmrZvkSRVK5ezr2VJbwUog2io/edit#gid=0 to share decks.

martincarrera commented 6 years ago

Hi!

If you could confirm the new cards ids I'll try to add them.

Thanks!

HZooly commented 6 years ago

Hi @martincarrera!

I can add new card ids. Where would you like to place them?

MaherFa commented 6 years ago

I support this, @AmirSavand have obtained a complete list from Reddit, see here (https://github.com/martincarrera/clash-royale-api/issues/109)

martincarrera commented 6 years ago

I will try to add the card ids this week, I'm currently super busy right now, so if you like you can add it on each card in the data generator as copyId and I'll update the API to support it, that way you could help A LOT!

HZooly commented 6 years ago

@AmirSavand @MaherFa If some of you starts the job, please tell us here. Don't do duplicate work!

martincarrera commented 6 years ago

Added copyId on each card.

If you see a wrong id please let me know as soon as possible.