martincostello / xunit-logging

Logging extensions for xunit
https://blog.martincostello.com/writing-logs-to-xunit-test-output/
Apache License 2.0
266 stars 11 forks source link

Support xunit v3 #718

Open martincostello opened 3 months ago

martincostello commented 3 months ago

Initial attempt at getting support for xunit v3.

Will likely require much more involved changes to be able to support v2 and v3 simultaneously (e.g. a new package). Visual Studio integration does not appear to work, and that's making it difficult to debug the fact that the message sink doesn't appear to be working.

Resolves #717.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.52%. Comparing base (6cae7de) to head (142e8a8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #718 +/- ## ========================================== + Coverage 97.78% 98.52% +0.73% ========================================== Files 15 15 Lines 271 271 Branches 37 37 ========================================== + Hits 265 267 +2 + Misses 3 2 -1 + Partials 3 2 -1 ``` | [Flag](https://app.codecov.io/gh/martincostello/xunit-logging/pull/718/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martin+Costello) | Coverage Δ | | |---|---|---| | [linux](https://app.codecov.io/gh/martincostello/xunit-logging/pull/718/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martin+Costello) | `97.04% <ø> (ø)` | | | [macos](https://app.codecov.io/gh/martincostello/xunit-logging/pull/718/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martin+Costello) | `97.78% <ø> (ø)` | | | [windows](https://app.codecov.io/gh/martincostello/xunit-logging/pull/718/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martin+Costello) | `98.52% <ø> (+1.47%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Martin+Costello#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.