search

martinctc / rwa

Package for running Relative Weights Analysis in R
https://martinctc.github.io/rwa
12 stars 8 forks source link

Feature: add bootstrap CI to the rwa method #6

Open martinctc opened 3 years ago

martinctc commented 3 years ago

Summary

This branch adds the bootstrap method to extract confidence intervals for rwa().

[NOTE: THIS IS STILL A DRAFT - REMOVE THIS LINE WHEN PULL REQUEST IS READY FOR REVIEW]

Changes

The changes made in this PR are:

  1. Change 1
  2. Change 2

Check

(OPTIONAL) Note

This fixes #1.

stonid commented 3 years ago

Hey Martin,

The code in there for review doesn't seem to match any of the material I sent for implementing the bootstrap. How can I best help integrate that?

Best, Scott T

On Tue, Jun 29, 2021 at 6:16 AM Martin Chan @.***> wrote:

@martinctc https://github.com/martinctc requested your review on: #6 https://github.com/martinctc/rwa/pull/6 Feature: add bootstrap CI to the rwa method.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/martinctc/rwa/pull/6#event-4952548928, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIT53LWAU2G7XD5VX5BQBADTVGMOLANCNFSM4XDUG75A .

martinctc commented 3 years ago

Hey Martin,

The code in there for review doesn't seem to match any of the material I sent for implementing the bootstrap. How can I best help integrate that?

Best, Scott T

On Tue, Jun 29, 2021 at 6:16 AM Martin Chan @.***> wrote:

@martinctc https://github.com/martinctc requested your review on: #6 https://github.com/martinctc/rwa/pull/6 Feature: add bootstrap CI to the rwa method.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/martinctc/rwa/pull/6#event-4952548928, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIT53LWAU2G7XD5VX5BQBADTVGMOLANCNFSM4XDUG75A .

Hey @stonid this pull request is still a draft and I haven't properly coded anything yet! Just wanted to add you to this, will ping you when it is ready for review.

stonid commented 3 years ago

Got it. I got a ping that I was supposed to review and was confused.

On Wed, Jun 30, 2021, 4:02 PM Martin Chan @.***> wrote:

Hey Martin,

The code in there for review doesn't seem to match any of the material I sent for implementing the bootstrap. How can I best help integrate that?

Best, Scott T

On Tue, Jun 29, 2021 at 6:16 AM Martin Chan @.***> wrote:

@martinctc https://github.com/martinctc https://github.com/martinctc requested your review on: #6 https://github.com/martinctc/rwa/pull/6

6 https://github.com/martinctc/rwa/pull/6 Feature: add bootstrap CI to

the rwa method.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub

6 (comment) https://github.com/martinctc/rwa/pull/6#event-4952548928,

or unsubscribe

https://github.com/notifications/unsubscribe-auth/AIT53LWAU2G7XD5VX5BQBADTVGMOLANCNFSM4XDUG75A .

Hey @stonid https://github.com/stonid this pull request is still a draft and I haven't properly coded anything yet! Just wanted to add you to this, will ping you when it is ready for review.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/martinctc/rwa/pull/6#issuecomment-871689891, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIT53LRCXHVXSKZ2ETKINDDTVNZ6JANCNFSM4XDUG75A .