martindevans / Cassowary.net

An incremental constraint solver for .NET

http://jozilla.net/Software/CassowaryNet

GNU Lesser General Public License v2.1

3 stars 5 forks source link

Test PassingValueIntoConstructor_SetsValueProperty fails on non-English locale system #4

Closed krypt-lynx closed 4 years ago

krypt-lynx commented 4 years ago

variable.ToString() outputs "[name:111,1]" (comma instead of period) on my system Looks like this (not checked others yet) using system default locale instead of CultureInfo.InvariantCulture

martindevans commented 4 years ago

That's a good point, I expect this same bug is duplicated in a few places. Would you be interested in submitting a PR just to add in the CultureInfo.InvariantCulture in the appropriate places?

krypt-lynx commented 4 years ago

I will do. Out of curiosity, what are you using this lib for?

martindevans commented 4 years ago

I will do.

Thanks ❤️

what are you using this lib for?

I'm not using it any more. Back when I developed it I was using it to procedurally generate 2D layouts of things e.g. facades for procedurally generated buildings (see the video at the bottom of this post if you're interested).

krypt-lynx commented 4 years ago

5

For whatever reason github does not allows to link existing issue in request

krypt-lynx commented 4 years ago

It is not what I expected, to be honest. I need a crossplatform constraints implementation to try to insert it into Unity game. And crossplatform support using native libs is a rabbit hole I don't want to dive into

martindevans commented 4 years ago

I've merged that PR, thanks very much :D