Bugfixes of MumbleGuiClient, and upgrading mumble.proto and protobuf-net to last versions

martindevans / MumbleSharp

An implementation of the mumble voice chat protocol in C#

http://martindevans.me

MIT License

93 stars 28 forks source link

Bugfixes of MumbleGuiClient, and upgrading mumble.proto and protobuf-net to last versions #26

Closed Meetsch closed 6 years ago

Meetsch commented 6 years ago

Hi,

Here are some few commits which: 1) Solves bugs in the MumbleGuiClient 2) Add user password and server port support to MumbleGuiClient 3) Upgrade MumbleSharp to latest version of protobuf-net protogen and mumble.proto 4) Upgrade to last version of NAudio

Sincerely yours,

Michel

martindevans commented 6 years ago

Wow this is great. I'll make some time to review the PR within a couple of days :)

martindevans commented 6 years ago

Looks good, thanks for the work.

If you're doing these kind of PRs in the future please try to keep them small - I'd rather review 10 small PRs than one beast of a PR with all the stuff packed into it :)