search

martindevans / SupersonicSound

C# Wrapper For FMOD Studio
Other
29 stars 9 forks source link

ChannelControl is not exposed #17

Closed martindevans closed 9 years ago

martindevans commented 9 years ago

Investigate the usage of ChannelControl and expose it appropriately in SSS

martindevans commented 9 years ago

D'oh! Channel extends ChannelControl. There may be some channel control functionality not exposed on the channel struct (specifically interested in callbacks), implement this.

martindevans commented 9 years ago

Also check channel group, probably needs all the same methods implemented

martindevans commented 9 years ago

Added IChannelControl which has the same signature as FMOD.ChannelControl. Added the interface to necessary structs (Channel and ChannelGroup).

Missing functionality is currently commented out within this interface

HakanL commented 9 years ago

Please see if this commit makes sense instead: https://github.com/HakanL/SupersonicSound/commit/a5fedb3d654dd5faf6e578780de66475f03d96a9

martindevans commented 9 years ago

Yep this looks pretty good - want to put that into a PR?

I didn't make myself clear with the whole IChannelControl stuff - in FMOD ChannelControl is the base class of Channel and ChannelGroup. ChannelControl is where setCallback is defined, so your commit is basically implementing part of the IChannelControl interface for me.

HakanL commented 9 years ago

Ah ok got it. I'll do a little more work on the callback before I do a PR, not too happy with keeping a list of callbacks, I'll try something else.

martindevans commented 9 years ago

Yeah I wanted you to submit a PR of just the first bit, without the list of callbacks. I want to experiment with alternatives to keeping a list because I don't like that either.

martindevans commented 9 years ago

This issue is resolved now, we got a little off track discussing it - we should move back over to here