martindholmes / BreezeMap

BreezeMap is a project to create a simple user interface for interactive map and facsimile editing based on TEI XML and OpenLayers 4+.
MIT License
11 stars 3 forks source link

Move explicit style declarations (currently in JS) to CSS #53

Closed gtnewton closed 4 months ago

gtnewton commented 2 years ago

In the hol.VectorLayer.prototype.parseSearch function we have this.docDisplayDiv.style.left = '-21rem'; If this was part of a CSS class it could be easily changed by users. The JS would then be used to swap classes instead of editing explicit values in JS.

martindholmes commented 4 months ago

@gtnewton Fixed in commit 87a9a2a. Closing this ticket.

martindholmes commented 4 months ago

@gtnewton To clarify: We now toggle a "hidden" class on the element to hide and show it. You can override the ruleset for that class.