search

martindstone / pagerduty-cli

A command line interface for PagerDuty
MIT License
91 stars 12 forks source link

Optionally snooze incidents when acking them #3

Closed facundofc closed 3 years ago

martindstone commented 3 years ago

Hi, thank you for your contribution! This looks good to me, with one exception -- the '-s' char is used for 'incident status' in other commands, and I would like to keep the char arguments consistent/unique across all the commands. Could you choose a different char (or no char) for the --snooze argument? I will also plan to implement a separate incident:snooze command in the future.

facundofc commented 3 years ago

Hi! I dig you striving for consistency. Chose 'z', that's not used anywhere else.

Also I did a minor modification to how the flag is handled. I hope you like it better now, I certainly do.

Cheers.

martindstone commented 3 years ago

This is great. Z is the perfect character for snooze 🤣 ... Just a note, the README.md is auto-generated by the publish, so you don't need to modify it (but it won't hurt anything either)