search

martindstone / pagerduty-cli

A command line interface for PagerDuty
MIT License
91 stars 13 forks source link

Increasing the allowed node version range to 16 or greater #52

Closed klcodanr closed 1 year ago

klcodanr commented 1 year ago

I use this CLI regularly on Node 18 and it gives me a warning while installing even though the CLI works:


npm WARN EBADENGINE   package: 'pagerduty-cli@0.1.15',
npm WARN EBADENGINE   required: { node: '^16', npm: '>=6.0.0' },
npm WARN EBADENGINE   current: { node: 'v18.6.0', npm: '8.13.2' }
npm WARN EBADENGINE }```

This PR updates the node version to be as permissive as the NPM version and support Node 16 or greater.
martindstone commented 1 year ago

Thank you!! This looks totally fine, I use it with node 18 too and really >=16 is what it should be... I will merge this as soon as possible and get an update out

klcodanr commented 1 year ago

Awesome! Thanks for the quick response!

klcodanr commented 1 year ago

Hi @martindstone any updates on this?

martindstone commented 1 year ago

Hey @klcodanr I am so sorry, just got busy with other stuff... I will merge and build now

martindstone commented 1 year ago

all done @klcodanr, sorry for the delay!

klcodanr commented 1 year ago

No problem and thanks for supporting this tool!