martindstone / pagerduty-cli

A command line interface for PagerDuty
MIT License
91 stars 13 forks source link

fix: use consistent formatting on user list as on user contact list. … #58

Closed jedelson-pagerduty closed 1 year ago

jedelson-pagerduty commented 1 year ago

…fixes #57

jedelson-pagerduty commented 1 year ago

@martindstone FYI - I get some errors running yarn test and yarn posttest (for linting) locally.

yarn test:

yarn run v1.22.19
$ nyc --extension .ts mocha --forbid-only "test/**/*.test.ts"

TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for /Users/jedelson/workspace/pagerduty-cli/test/commands/hello.test.ts
    at new NodeError (node:internal/errors:372:5)
    at Object.getFileProtocolModuleFormat [as file:] (node:internal/modules/esm/get_format:76:11)
    at defaultGetFormat (node:internal/modules/esm/get_format:118:38)
    at defaultLoad (node:internal/modules/esm/load:21:20)
    at ESMLoader.load (node:internal/modules/esm/loader:407:26)
    at ESMLoader.moduleProvider (node:internal/modules/esm/loader:326:22)
    at new ModuleJob (node:internal/modules/esm/module_job:66:26)
    at ESMLoader.#createModuleJob (node:internal/modules/esm/loader:345:17)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:304:34)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:385:24)
    at async importModuleDynamicallyWrapper (node:internal/vm/module:437:15)
    at async formattedImport (/Users/jedelson/workspace/pagerduty-cli/node_modules/mocha/lib/nodejs/esm-utils.js:9:14)
    at async Object.exports.requireOrImport (/Users/jedelson/workspace/pagerduty-cli/node_modules/mocha/lib/nodejs/esm-utils.js:42:28)
    at async Object.exports.loadFilesAsync (/Users/jedelson/workspace/pagerduty-cli/node_modules/mocha/lib/nodejs/esm-utils.js:100:20)
    at async singleRun (/Users/jedelson/workspace/pagerduty-cli/node_modules/mocha/lib/cli/run-helpers.js:125:3)
    at async Object.exports.handler (/Users/jedelson/workspace/pagerduty-cli/node_modules/mocha/lib/cli/run.js:370:5)
----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------|---------|----------|---------|---------|-------------------
All files |       0 |        0 |       0 |       0 |                   
----------|---------|----------|---------|---------|-------------------
error Command failed with exit code 1.

yarn posttest:

yarn run v1.22.19
$ eslint . --ext .ts --config .eslintrc

Oops! Something went wrong! :(

ESLint: 8.34.0

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Failed to load plugin 'unicorn' declared in '--config » eslint-config-oclif': Package subpath './lib/rules/no-warning-comments' is not defined by "exports" in /Users/jedelson/workspace/pagerduty-cli/node_modules/eslint/package.json
Referenced from: /Users/jedelson/workspace/pagerduty-cli/node_modules/eslint-config-oclif/index.js
    at new NodeError (node:internal/errors:372:5)
    at throwExportsNotFound (node:internal/modules/esm/resolve:472:9)
    at packageExportsResolve (node:internal/modules/esm/resolve:753:3)
    at resolveExports (node:internal/modules/cjs/loader:482:36)
    at Function.Module._findPath (node:internal/modules/cjs/loader:522:31)
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:919:27)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/Users/jedelson/workspace/pagerduty-cli/node_modules/eslint-plugin-unicorn/rules/expiring-todo-comments.js:5:18)
error Command failed with exit code 2.

Any idea what's going on there?

I'm using node v16.15.0 which is the same as that specified in the .node-version file.