Closed sighingnow closed 1 year ago
The number looks not well, and it does work and I would look into the number further.
I disagree! The numbers for vineyard and plasma are about the same in delta-memory (system memory) and time. Why and how the "unique" appears higher, I am not sure, perhaps how memory is reported is different between the systems; but certainly the performance is greatly beating pickle on your system. At a guess, I would say that your memory is more constrained than mine.
Note that a lot of things will impact what we see (config, systems, choice of workflow), and the benchmarks here should be seen as a starting point from which we can work out something more robust.
I updated the README with latest timings on my system. Note that even the order of the tests might be material.
and the benchmarks here should be seen as a starting point from which we can work out something more robust.
Totally agree.
The number looks not well, and it does work and I would look into the number further.
Edit: I have made a mistake in the "cache" part of vineyard implementation. After the bug fixed vineyard looks faster than plasma and I think there are still much optimization spaces inside the vineyard itself.
The difference comes from the performance difference of
_put_vineyard_buffer
and_put_plasma_buffer
. I have added a timing decorator in https://github.com/martindurant/distributed/pull/2.Hope the above information could be helpful.
Address #2