search

martinfabian / MFXlist

https://forum.cockos.com/showthread.php?t=248411
5 stars 1 forks source link

Focus stealing issue... #1

Closed martinfabian closed 3 years ago

martinfabian commented 3 years ago

There is some type of focus-stealing going on. Click an FX, while its window is open, spacebar works as play. But click again (on MFXlist) to close the floating window. Now spacebar does NOT play! WTF sorcery is this?

So it seems that focus has to be given back to the arrange view, otherwise spacebar does not play

Discussion on this here https://forum.cockos.com/showthread.php?t=161000, "SWS/BR: Focus arrange on mouse release" But there is also SWS/BR: Focus tracks, maybe that one is more suitable?

martinfabian commented 3 years ago

I would want to avoid SWS though, but maybe it cannot be avoided here?

Also, maybe this focus issue is related to incorrect scroll wheel, Issue #2 ?

martinfabian commented 3 years ago

YES! Adding rpr.Main_OnCommand(MFXlist.CMD_FOCUSTRACKS, 0) after Alt+left click action permits to Alt+left click delte an FX and then immediately to Ctrl+z undo!

So adding focusTCP() in strategic places solves most of the issues, but not all. One important issue that remains is if a window is opened by clicking or Ctrl-clicking in MFXlist, and then the user closes that window by hitting ESC or clicking the the upper right x, then MFXlist does not get notified that the window was closed and cannot focus the TCP.

martinfabian commented 3 years ago

Fixed now it seems, by managing a list of open windows, and focusing the TCP whenever such a window has been externally closed.