search

martinfabian / MFXlist

https://forum.cockos.com/showthread.php?t=248411
5 stars 1 forks source link

User re-named FX are handled incorrectly when FX type is shown... #26

Closed martinfabian closed 3 years ago

martinfabian commented 3 years ago

When FX type (JS: VST: VSTi:, VID:) is shown, that is, when MFXlist.SHOW_FXTYPE == true, then all FX that do not have teh type in their name are given the suffix "VID:", which means that they show as Video processor FX. However, when the user has renamed an FX, the prefix may have been removed, and then two things:

  1. The prefix "VID:" is (incorrectly) added, and
  2. MFXlist really has no idea what type of FX it is.

Also, for the video processor "Equirectangular/spherical 360 panner - video processor", the "Equirectangular/" is removed due to the pruning of the FX name that Gavin implemented. The same happens with "Shadow/midtone/highlight RGB adjust - video processor", and "Brightness/Contrast - video processor", and maybe others.

Personalty I do not see the use of having these prefixes in MFXlist, but people have asked for it, and Gavin made a pull request with a solution to it, so apparently some people find it useful. It is a bit of a hassle, though.

martinfabian commented 3 years ago

Another example, I renamed ReaEQ to the not-so far-fetched: ReaEQ/cut below 200/above 2000 This shows as "above 2000"

martinfabian commented 3 years ago

This needs to be reworked, we cannot rely on the type being in the name, since the user may have renamed the FX. The type can be found by plug_type = reaper.TrackFX_GetIOSize(track, fx), and here we know that 2 == JS and 3 == VST, but the others (VSTi, video) need to be found out by experimentation.

martinfabian commented 3 years ago

FX type numbers seem to be:

martinfabian commented 3 years ago

This was partly fixed in v0.9.7, except for DX/DXi since I have no idea what Reaper returns for.