martinfabian / MFXlist

https://forum.cockos.com/showthread.php?t=248411
5 stars 1 forks source link

Annoying focus stealing after close FX browser... #32

Open martinfabian opened 3 years ago

martinfabian commented 3 years ago
  1. Click in track area, below any FX.
  2. The FX browser opens.
  3. Click again, or Cancel the FX browser, or hit ESC, now MFXlist has the focus and key strokes do not go through to Reaper.

Also, if after 2 above, and FX is added, the FX chain for the track opens. Closing it by x-clicking, or ESC, again MFXlist steals the focus.

Closing the FX chain by Ctrl-clicking the newly added FX, does not steal the focus!

martinfabian commented 3 years ago

Probably must find a way to get also the FX browser on the openwin_list. However, that requires a change of the elements that are put on the list, since the FX browser cannot be identified by {track, fxid} as the FX float and FX chain windows can. Maybe negative fxidcould indicate the FX browser?

martinfabian commented 3 years ago

Comments on lines 1230-1240 in the main branch:

      -- Two issues introduced here:
      -- 1. The track selection changes, this is necessary since that is the way that the FX browser
      --    knows which track to add to. fxlist does the same. But clicking an empty slot in the
      --    mixer does not change the track selection. Maybe store track selection before and then
      --    restore it after opening teh FX browser? 
      -- 2. Clicking once opens the FX browser, clicking again closes it. MFX then gets the focus,
      --    and then the focus is stolen so no key strokes go to Reaper. And I see no way to query 
      --    the FX browser window's state, or how to put it on openwin_list. Keeping track of the
      --    state myself is not a solution, as the window can be closed by ESC, Cancel, or upper 
      --    right X. Also, when clicking OK in teh FX browser, teh FX chain window opens. Closing
      --    one again gives focus to MFX, and the focus is stolen.