search

martinfekete10 / Tuneful

Tuneful is a native macOS menu bar playback control app for Spotify and Apple Music
https://martinfekete.com/Tuneful/
MIT License
284 stars 4 forks source link

Clicking on the menu bar doesn't toggle #80

Closed robinplace closed 3 months ago

robinplace commented 5 months ago

Love this app! This is a small ask; I might put up a PR if i get a chance.

MacOS's built in menus, as well as most apps', treat clicking on them in the menu bar as a toggle. If you click on the top bar menu once to open the menu or popover, clicking on the menu again closes the popover.

With Tuneful, clicking on the menubar again does a funny little glitchy "hide and then reshow" thing.

Again a small thing. Thanks for the excellent app @-martinfekete10!

robinplace commented 5 months ago

Oh the Swift code here looks super approachable.

This's probably as easy as adjusting showPopover to togglePopover and throwing in a little conditional to check popover.isShown.

martinfekete10 commented 3 months ago

Hey, I just released a new version of Tuneful with your fix included, thank you very much :)