martinfleis / urban-block-artifacts

A shape-based heuristic for the detection of urban block artifacts
11 stars 0 forks source link

added y-distance comp peak/valley #24

Closed anastassiavybornova closed 1 year ago

anastassiavybornova commented 1 year ago

added the y-diff computation as discussed, and re-ran all result computation and plotting

martinfleis commented 1 year ago

Is it fair to say that results[city][option]["y_heights"] always has a list of ['left', 'right', 'valley'] so we can use it to measure both y distances? Not just the max as you do now. I would like to have 'y_diff_left' and 'y_diff_right' so we can report both.

anastassiavybornova commented 1 year ago

@martinfleis does that work if i continue adding stuff to this branch (within the 04x peaks notebooks) and we merge it later?

martinfleis commented 1 year ago

Yeah

anastassiavybornova commented 1 year ago

@martinfleis ready to be merged!