Integration with github.com/golang/oauth2

ahmetb commented 10 years ago

Fixes #23.

I'm not sure if people should pass *golang/oauth2.Options or *martini-contrib/oauth2.Options. That's why I removed the Options type from here since it has nothing more than golang/oauth2 one and we're copying fields one by one (which might be prone to errors in the future). AuthUrl and TokenUrl was not the right place for this type anyway.
Another problem might be the marshaled token types are not exactly the same in the old lib and the new lib. So that might give some trouble to the apps updating it.
Breaking changes
- requires package: github.com/golang/oauth2
- no longer requires package: code.google.com/p/goauth2/oauth
- caller code should use Options type from not this oauth2 but golang's oauth2 (not sure if it was the right choice)

rakyll commented 10 years ago

Left some comments, LGTM otherwise.

We had a plan to inject a oauth2.Transport rather than tokens, but it can wait.

rakyll commented 10 years ago

Yay, merging! Thanks much.

martini-contrib / oauth2