search

martini-contrib / oauth2

[not maintained] Allows your Martini application to support user login via an OAuth 2.0 backend.
Apache License 2.0
125 stars 47 forks source link

support to new design the API golang.org/x/oauth2 #45

Closed weslleyandrade closed 9 years ago

weslleyandrade commented 9 years ago

the project "golang/oauth2" recommended this change.

weslleyandrade commented 9 years ago

@rakyll i fix the issues that you pointed. sorry the errors, I always forget to run tests :(

weslleyandrade commented 9 years ago

@rakyll Again I corrected the requested notes. I took the opportunity to incorporate the changes made to the API (https://go-review.googlesource.com/#/c/2195/)

shackra commented 9 years ago

Uh, hope this get merged soon! my issue #47 is really a stopper

rakyll commented 9 years ago

Please squash your commits.

weslleyandrade commented 9 years ago

done.

weslleyandrade commented 9 years ago

@dougbarrett you're right in my last commiti against the correction

@rakyll you think necessary squash

dougbarrett commented 9 years ago

@weslleyandrade @rakyll just wondering what the status of this is? The live package is broken at this point, and this will fix it.

Thanks!

rakyll commented 9 years ago

Please squash and address the comments I've left, then we can merge.

weslleyandrade commented 9 years ago

@rakyll Done.

rakyll commented 9 years ago

Thanks.