Add XML rendering - Githubissues

martini-contrib / render

Martini middleware/handler for easily rendering serialized JSON, XML, and HTML template responses.

MIT License

245 stars 57 forks source link

Add XML rendering #27

Closed mdlayher closed 10 years ago

mdlayher commented 10 years ago

Adds functionality requested in #25.

unrolled commented 10 years ago

This looks good. Just a couple of things to tweak.

One comment says json, should say xml in render.go.
Please add an example below the json example at the top of the render.go file.
Please add two the xml examples (again below the json ones) to the Character Encodings section of the README.md file.

Fix those up and we'll land this one.

mdlayher commented 10 years ago

Will do this afternoon! Thanks for the feedback! On May 14, 2014 12:31 PM, "Cory Jacobsen" notifications@github.com wrote:

This looks good. Just a couple of things to tweak.

One comment says json, should say xml in render.go.

Please add an example below the json example at the top of the render.go file.

Please add two the xml examples (again below the json ones) to the Character Encodings section of the README.md file.

Fix those up and we'll land this one.

— Reply to this email directly or view it on GitHubhttps://github.com/martini-contrib/render/pull/27#issuecomment-43104075 .

mdlayher commented 10 years ago

All done! Let me know if you need anything else from me.

unrolled commented 10 years ago

Awesome, merged.

mdlayher commented 10 years ago

Thank you! I also noticed that the repository description just says JSON and HTML, and since I can't send a PR for that, could you update that to add XML? Thanks for your time!

unrolled commented 10 years ago

Description has been updated. Thanks for tackling this!