martinjonsson01 / contract-portal

A website for working with a contract portfolio that can be bought into by other corporations. The central function of the portal allows for viewing these contracts and using them to receive discounts on purchases.

6 stars 1 forks source link

Resize contract cards #159

Closed martinjonsson01 closed 2 years ago

martinjonsson01 commented 2 years ago

Description

As a customer I want the contract cards to be smaller, so that I can view more of them at once.

Acceptance criteria

[x] On a 13" laptop screen, 4 columns (no more than 4) of cards are visible
[x] Two rows of cards should be visible on a 13" laptop screen (given enough contracts in the database)
[x] Take a look at spacing

JacobBredin commented 2 years ago

142 should probably be merged into master before someone starts on this one.

martinjonsson01 commented 2 years ago

142 should probably be merged into master before someone starts on this one.

How come? This story should mostly concern styling, while #142 was mostly technical.

JacobBredin commented 2 years ago

How come?

Nevermind, I thought you made larger changes to the HTML code of the contract than you did.

martinjonsson01 commented 2 years ago

I thought you made larger changes to the HTML code of the contract than you did.

Ah, yeah I mostly reformatted it so the lines weren't 800 characters long 😝

JacobBredin commented 2 years ago

Is it overkill to refactor some of the code, seems like a lot of copy and paste right now?

martinjonsson01 commented 2 years ago

Refactor what? The styling?

JacobBredin commented 2 years ago

Inside ContractCard there are 4 divs that handle onclick addToRecentlyViewed, there must be some better way of doing that.

martinjonsson01 commented 2 years ago

Oh, yeah that's not very good.

there must be some better way of doing that

I believe it should be enough to put the onclick on the same element that opens the card details view, now that I've reconfigured how the event cascading occurs. ... But that's still in #142😛