Open martinjrobins opened 6 months ago
needs to be done to all the callable functions, but perhaps start with call_inplace
and see if there is any unexpected problems
I'm a bit unsure doing this is worth the increased complexity. Could just use diffsl for concatenating solves.....
however, it would allow me to reduce the amount of allocated memory for the solvers. Bdf solver stores diff
as well as y
and dy
, even tho these overlap somewhat, simply because we need a separate vector for the state, and the op calls
atm the main call function for
NonLinearOp
is:To make this more flexible, we should use VectorView and VectorViewMut instead, ie:
This allows algorithms to call these functions with views rather than references to owned vectors. One usecase for this is to concatentate solves with varying parameters into a larger statevector