martinjw / Holiday

Calculate Public Holidays
MIT License
208 stars 82 forks source link

IrelandPublicHoliday considers weekends when it shouldn't #111

Closed Bjornsen016 closed 11 months ago

Bjornsen016 commented 11 months ago

From my understanding the following Public Holidays in Ireland does not move if there is a weekend.

MayDay in Ireland should be the First Monday in May. As of now IrelandPublicHoliday takes 1 May (with weekend fix).

All of the info above is taken from the link below. https://www.citizensinformation.ie/en/employment/employment-rights-and-conditions/leave-and-holidays/public-holidays/#lc3a51

I can make a PR to fix this if you want to.

martinjw commented 11 months ago

Agreed, Monday rules apply only to St Brigid, Easter, May day, June, August, October holidays. PR would be welcome! Thanks