martinjw / Holiday

Calculate Public Holidays
MIT License
208 stars 82 forks source link

Ensure that the assembly has a strong name #130

Closed siimav closed 5 months ago

siimav commented 5 months ago

This step is necessary so that the library could be used in projects that require DLLs to be deployed to GAC. Ref: https://learn.microsoft.com/en-us/dotnet/standard/assembly/sign-strong-name

martinjw commented 5 months ago
siimav commented 5 months ago

The GH doc does say the following:

Because of the viral nature of strong-naming, it is recommended that publicly published .NET libraries are strong-named.

In my experience most libraries published on Nuget do follow this. I see that there's not much point in arguing about this further though.

siimav commented 5 months ago

Btw, StrongNamer doesn't work with .net framework versions newer than 4.6.x

martinjw commented 5 months ago

Indeed, my company uses a local fork of strongNamer updated to 4.8- using public PRs to the strongNamer repo. A pity there's no nuget.org package.