search

martinkasa / capacitor-secure-storage-plugin

Capacitor plugin for storing string values securly on iOS and Android.
MIT License
153 stars 55 forks source link

Unicode support for web #25

Open lucaboy opened 3 years ago

martinkasa commented 3 years ago

Hello @lucaboy, is this supose to be real pull request? or are you just making changes to your forked copy?

cies commented 2 years ago

Not using Exception when not strictly needed is always a good idea, IHMO. Returning null is a bit of a weak alternative as all types of errors are now simply combined into one undifferentiatable NULL value.

IMHO, best would be to have a typed Result response what has all error states (maybe a enum and a description String that possibly contains the error from the underlying library), and all success states (in this case only one: the value that belongs to the key).

https://developer.paypal.com/braintree/docs/reference/general/result-objects/node