search

martinkasa / capacitor-secure-storage-plugin

Capacitor plugin for storing string values securly on iOS and Android.
MIT License
152 stars 53 forks source link

Access secure storage when device is locked(ios) #47

Closed abishekilango-wayfwd closed 2 years ago

abishekilango-wayfwd commented 2 years ago

Fixes #46

This PR makes iOS plugin behavior consistent with android.

Please refer to jrendel/SwiftKeychainWrapper#95 for more info.

martinkasa commented 2 years ago

Hi @abishekilango-wayfwd, is it enough to add it just to set method? what about get? that one is working without accessibility flag?

abishekilango-wayfwd commented 2 years ago

Yes, I have tested it on iOS simulator. get works without the accessibility flag. But it can be added in the dedicated set in the get method so that keys migrated from the standard keychainwrapper have the same behavior. I'm adding it.

I should also mention that older keys that were already set without the accessibility flag will still have the old behavior.