martinkasa / capacitor-secure-storage-plugin

Capacitor plugin for storing string values securly on iOS and Android.
MIT License
152 stars 53 forks source link

Upgrade to Capacitor v4 #59

Closed de-dan closed 2 years ago

de-dan commented 2 years ago

PR for #58

richardkshergold commented 2 years ago

Looking forward to this PR being merged as we are wanting to migrate our app to Capacitor V4. Thanks!

Chuckv01 commented 2 years ago

@martinkasa merge and publish this pretty please?

NikSteel commented 2 years ago

Looking forward to this update as well 🙂

AliMejbar commented 2 years ago

Tested it and it works fine for me , looking forward for the merge !

martinkasa commented 2 years ago

@de-dan Thank you for this nice and complete PR. I am sorry for merging this so late. I have tested iOS, but I did not manage to test Android, so I hope it is working as well :)

mraible commented 1 year ago

Is it possible to get a new release with this fix?

I tried to integrate it with the following in my package.json:

  "overrides": {
    "capacitor-secure-storage-plugin": "martinkasa/capacitor-secure-storage-plugin"
  }

However, when I run ionic build, I get a compile error.

./node_modules/ionic-appauth/lib/capacitor/capacitor-secure-storage.js:2:0-70 - Error: Module not found: 
Error: Can't resolve 'capacitor-secure-storage-plugin' in '/.../ionic-app/node_modules/ionic-appauth/lib/capacitor'
mraible commented 1 year ago

I was able to get past the issue above. Now I just need a release of this library to add Capacitor 4 support to Ionic AppAuth. Pretty please? 😊

martinkasa commented 1 year ago

Hi @mraible, version 0.8.0 with Capacitor v4 support was released few day ago. I am not sure what do you need to be honest :)

mraible commented 1 year ago

I'm sorry, I didn't realize a release was available because I didn't see anything under releases or tags. Thank you!

martinkasa commented 1 year ago

Yeah.. sorry for confusion. I used "release-it" package before, but after reinstallation of my laptop I have not installed it again and release the package simply by npm publish, which do not create github release. But thanks for feedback, I will try to not forget to use it in future.