Add optional "serviceName" property to all service methods

martinkasa / capacitor-secure-storage-plugin

Capacitor plugin for storing string values securly on iOS and Android.

MIT License

152 stars 53 forks source link

Add optional "serviceName" property to all service methods #82

Open kiwi-josh opened 11 months ago

kiwi-josh commented 11 months ago

Resolves: https://github.com/martinkasa/capacitor-secure-storage-plugin/issues/51

Optionally allow serviceName to be provided when calling the methods, defaulting to the existing "cap_sec" if not provided to maintain backwards compatibility

de-dan commented 3 months ago

+1 but

[ ] Android implementation missing
[ ] I get that in the iOS implementation your new serviceName property is actually used as serviceName for the KeychainWrapper, but in Web the property is used for the storage entry key. So I would suggest a more global naming like prefix or keyPrefix