martinklepsch / boot-garden

Boot task to compile Garden stylesheets.
Eclipse Public License 1.0
37 stars 6 forks source link

Update to garden 1.3.0 #11

Closed livtanong closed 8 years ago

martinklepsch commented 8 years ago

:+1: PR most welcome!

livtanong commented 8 years ago

I'm a little hesitant, because I had to remove something to make it work. What I've done so far is remove the :refresh keyword from garden-pods. Keeping it in causes a java.io thread error, and removing it fixes the problem. Not sure if that breaks anything else.

dgellow commented 8 years ago

What's the status of this issue?

martinklepsch commented 8 years ago

@dgellow @levitanong there are some changes queued for the next release of boot that might remove the need for any specific workarounds as done in #14.

I'd like to verify the workarounds are still required with the coming release before adding them to the codebase. Does this sound ok to you?

livtanong commented 8 years ago

I remember someone mentioning an evergreen feature of boot on hipchat. Is this it?

Regardless, you’re right, we should wait for the coming release (and even then, garden 1.3.0 is still a snapshot) before doing anything.

On 7 Nov 2015, at 11:12, Martin Klepsch notifications@github.com wrote:

@dgellow https://github.com/dgellow @levitanong https://github.com/levitanong there are some changes https://github.com/boot-clj/boot/compare/2.4.2...master queued for the next release of boot that might remove the need for any specific workarounds as done in #14 https://github.com/martinklepsch/boot-garden/pull/14.

I'd like to verify the workarounds are still required with the coming release before adding them to the codebase. Does this sound ok to you?

— Reply to this email directly or view it on GitHub https://github.com/martinklepsch/boot-garden/issues/11#issuecomment-154740631.

martinklepsch commented 8 years ago

What evergreen feature of boot do you mean? I'm afraid I didn't understand the first portion of your comment :)

I think the next boot release is around the corner so we shouldn't have to wait very long :) On Sun, 8 Nov 2015 at 09:21, Levi Tan Ong notifications@github.com wrote:

I remember someone mentioning an evergreen feature of boot on hipchat. Is this it?

Regardless, you’re right, we should wait for the coming release (and even then, garden 1.3.0 is still a snapshot) before doing anything.

On 7 Nov 2015, at 11:12, Martin Klepsch notifications@github.com wrote:

@dgellow https://github.com/dgellow @levitanong < https://github.com/levitanong> there are some changes < https://github.com/boot-clj/boot/compare/2.4.2...master> queued for the next release of boot that might remove the need for any specific workarounds as done in #14 < https://github.com/martinklepsch/boot-garden/pull/14>.

I'd like to verify the workarounds are still required with the coming release before adding them to the codebase. Does this sound ok to you?

— Reply to this email directly or view it on GitHub < https://github.com/martinklepsch/boot-garden/issues/11#issuecomment-154740631 .

— Reply to this email directly or view it on GitHub https://github.com/martinklepsch/boot-garden/issues/11#issuecomment-154788967 .

dgellow commented 8 years ago

@martinklepsch

I'd like to verify the workarounds are still required with the coming release before adding them to the codebase. Does this sound ok to you?

It sounds totally fine to me :) I'll wait your release before moving my project to Garden 1.3.0.

Btw thank you for your work.

livtanong commented 8 years ago

@martinklepsch iirc, someone somewhere mentioned something about boot decoupling dependency versions, and keeping all the things up to date. But I could've been high at the time.

https://github.com/noprompt/garden Garden is now stable at 1.3.0!

martinklepsch commented 8 years ago

@levitanong Hey! I just pushed a new version 1.3.0-0 that should come with Garden 1.3.0 — give it a try :+1:

livtanong commented 8 years ago

@martinklepsch works perfectly. Thanks man!

martinklepsch commented 8 years ago

Cool, thanks for letting me know! :)