search

martinklepsch / electron-and-clojurescript

💡 Make an electron app with nothing but ClojureScript!
MIT License
148 stars 21 forks source link

Fix to work with latest electron #1

Closed YurySolovyov closed 7 years ago

YurySolovyov commented 7 years ago

Hey, thanks for creating this, I updated some calls to work with latest electron. Not sure if I can destructure electron thing, but I can make the changes if you tell me how.

martinklepsch commented 7 years ago

Hey @YurySolovyov thanks for working on this! 👍

Not sure if I can destructure electron thing, but I can make the changes if you tell me how.

Not sure what you mean here, are you referring to app & BrowserWindow? If so these can't be destructured and have to be retrieved via interop forms (like you did).

How have you tested this? I don't have the capacity right now to test myself but if you say it's working I'll trust you and merge it :) Thanks again!

YurySolovyov commented 7 years ago

@martinklepsch I did

boot watch dev-build

and then

electron target

works for me :)

martinklepsch commented 7 years ago

@YurySolovyov thank you very much! 👍

YurySolovyov commented 7 years ago

@martinklepsch I can also try to update main deps to latest stables and submit PR if it works

martinklepsch commented 7 years ago

@YurySolovyov you are more than welcome to :)