martinklepsch / s3-beam

🚀 direct-to-S3 uploading using ClojureScript
Eclipse Public License 1.0
92 stars 17 forks source link

readme needs adjument? (custom signing url) #12

Closed GetContented closed 8 years ago

GetContented commented 8 years ago

There's a custom URL in the source (: server-url in opts), but the readme currently lists custom signing url as being one of the nice to haves. Or, have I missed something here? Readme should be updated if I haven't missed anything.

Also, how is upload progress coming along? or not?

martinklepsch commented 8 years ago

Hi Julian, you're right. We added the addition of the :server-url option to the changelog but didn't adapt the rest of the readme. PR syncing those things up would be very welcome! :)

GetContented commented 8 years ago

@martinklepsch ok, I did a tiny PR. I think this is all that's required - I realised the readme already references the custom server URL.