Use AWS Java SDK for signing URL

danielcompton commented 7 years ago

We should investigate whether it is possible to use the AWS Java SDK to sign URLs. This would let us support v4 signing format, as well as letting users use the credential chain rather than needing to provide access keys. One thing to watch out for is the dependencies that this might bring along with it.

danielcompton commented 4 years ago

https://docs.aws.amazon.com/AmazonS3/latest/dev/ShareObjectPreSignedURLJavaSDK.html has docs on how to do this.

danielcompton commented 4 years ago

I took a look at this, my findings:

AWS Java SDK v2 doesn't support generating presigned URLS yet - https://github.com/aws/aws-sdk-java-v2/issues/203
AWS Java SDK v1 creates presigned URLs using virtual-host style URLs, even if the bucket name has a . in it - https://github.com/aws/aws-sdk-java/issues/2105, and https://github.com/aws/aws-sdk-java/issues/628
AWS Java SDK v1 doesn't seem to create v4 presigned URLs, though I don't think we do now either - #34, https://github.com/aws/aws-sdk-java/issues/834

Given that there is no urgency to move, I suggest waiting to see if either of these SDK's add support for presigned URLs with "." in the bucket name.

martinklepsch / s3-beam

Use AWS Java SDK for signing URL #38