search

martinklepsch / s3-beam

🚀 direct-to-S3 uploading using ClojureScript
Eclipse Public License 1.0
92 stars 17 forks source link

Add progress events #40

Closed iGEL closed 7 years ago

iGEL commented 7 years ago

What do you think about this?

Paired on with @yundt

danielcompton commented 7 years ago

This looks pretty reasonable, I'll just need to take a closer look to make sure the API changes are ok. Thanks!

danielcompton commented 7 years ago

I wish GitHub's review system didn't feel so negative when I requested changes. It makes me feel like I've put a big red x all over it, when that's not how I feel at all...

iGEL commented 7 years ago

Thanks for the review, @martinklepsch & @danielcompton. I addressed the issues, would be nice if you could have another look.

martinklepsch commented 7 years ago

Looking good to me 👍 Thanks for taking the time!

danielcompton commented 7 years ago

I've pushed an alpha3 version to GitHub, @martinklepsch are you able to deploy to Clojars? @iGEL once it's all deployed and you're using it in production, can you report back in a week with any progress? (ba dum tish)

If it's all good then we can release an 0.6.0. Thanks!

iGEL commented 7 years ago

Thanks for the support and merge!

Unfortunately we're still a few weeks away from production usage. Also, we have very few (but valuable) users, a proper cross browser test will be more telling. Hope that someone has a better test field.

martinklepsch commented 7 years ago

@danielcompton @iGEL Hey folks, I just pushed to Clojars:

[org.martinklepsch/s3-beam "0.6.0-alpha3"]

Sorry for the delay on this and nice work everyone :)