aws-zone not required when passing custom upload-url

[benhowell]

I'm using s3-beam for DigitalOcean spaces and therefore using custom upload-url. However, the handler checks for aws-zone and bombs out if it's not there.

As a work-around, you can set any arbitrary aws zone (e.g. "us-east-1") as it's not used in the hash or anything.

Thanks!

[martinklepsch]

Hey @benhowell, that's a good point — would you be interested in making a PR? I'm thinking the following might be helpful for you and others:

• A note in the Readme that this also works with DO's Spaces
• Change the aws-zone assertion so that it is only checked when upload-url url is not provided

Would be happy about your contribution 🙌

[benhowell]

Sure, I'll put it on my todo list! I'll leave the issue open until I fix it :+1:

[benhowell]

Done :-)

[benhowell]

Reopening until pulled or otherwise

[martinklepsch]

Haven’t cut a release yet but will try to do so later today. Thanks :) On Sun 26. Nov 2017 at 03:37, Ben Howell notifications@github.com wrote:

Closed #44 https://github.com/martinklepsch/s3-beam/issues/44.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/martinklepsch/s3-beam/issues/44#event-1358014714, or mute the thread https://github.com/notifications/unsubscribe-auth/AAF82NU7o-sXUNoC0eZLBbb3EYwK-pukks5s6M7SgaJpZM4PoRIl .

[martinklepsch]

Alright I cut 0.6.0-alpha4 now — I stripped down the Digital Ocean specific documentation quite a bit, feeling that people are best of just referring to the official docs.

[benhowell]

Thanks! :+1: