search

martinklepsch / tenzing

⚡️ Clojurescript application template using Boot
Eclipse Public License 1.0
404 stars 39 forks source link

Add +test option #28

Closed crisptrutski closed 9 years ago

crisptrutski commented 9 years ago

Refs #27

Some obvious areas for improvement:

  1. Having issues with some environments, eg. slimerjs is not showing output, and node chokes on absolute file paths. Will submit patches upstream.
  2. clojure.core/test is clobbered. Is there a (:refer-clojure :exclusions [...]) mechanism for build.boot files?
  3. Test runner is very aggressive about what namespaces are tested - testing regular project namespaces, and even some namespaces outside the project. Could perhaps limit itself to specific source-paths, and perhaps even use a filename regex (so /tests/fixtures.cljs would not be run for example).
  4. The mechanism for "invading" the build (stripping all .cljs.edn, and getting a new one generated) is too drastic, and also gives no control over what code is required (so everything is required). Generating a bespoke .cljs.edn, and (if boot-cljs gets this feature) targeting it directly, would prov.
  5. Along the lines of (3), it should be possible to use an existing .cljs.edn file, and just add the :require on the suite.

Moving back a step - starter test suites specifically for Reagent and Om would be nice.

On a code note - adding extra tasks is quite messy without #2

martinklepsch commented 9 years ago

Looks great from a quick glance. I'll try to give it a test run after ClojureBridge here.

crisptrutski commented 9 years ago

Thanks for spotting - updated, and you can preview here: https://github.com/crisptrutski/tenzing/blob/master/README.org

martinklepsch commented 9 years ago 
lein new tenzing testing-testing +reagent +test --snapshot

testing now..

martinklepsch commented 9 years ago 
Cannot run program "rhino"

Maybe adding a check to boot-cljs-test if the runner programs are available would be a good idea?

crisptrutski commented 9 years ago

Sounds good. Commands are called by do directly, so will PR there On 15 Jul 2015 5:45 PM, "Martin Klepsch" notifications@github.com wrote:

Cannot run program "rhino"

Maybe adding a check to boot-cljs-test if the runner programs are available would be a good idea?

— Reply to this email directly or view it on GitHub https://github.com/martinklepsch/tenzing/pull/28#issuecomment-121657383.

martinklepsch commented 9 years ago

Other than that looking pretty sweet :) Now I only need to write tests lol

crisptrutski commented 9 years ago

:palm_tree: :cocktail: (coconut)

crisptrutski commented 9 years ago

coconut