search

martinklepsch / tenzing

⚡️ Clojurescript application template using Boot
Eclipse Public License 1.0
403 stars 39 forks source link

README.md: boot implicit target directory creation no longer exists, i.e., no files to copy #60

Closed gamecubate closed 8 years ago

gamecubate commented 8 years ago

Per README.md, Since Tenzing comes without a backend you can easily deploy your app to Amazon S3 or even host it in your Dropbox. To do that just copy the files in target/ to your desired location.

Unfortunately, boot no longer does implicit target directory creation, which means that these instructions fail.

martinklepsch commented 8 years ago

Good catch! :) a PR updating those instructions would be welcome :+1: On Sun, 1 May 2016 at 15:34, Alexandre Rousseau notifications@github.com wrote:

Per README.md, Since Tenzing comes without a backend you can easily deploy your app to Amazon S3 or even host it in your Dropbox. To do that just copy the files in target/ to your desired location.

Unfortunately, boot no longer does implicit target directory creation, which means that these instructions fail.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/martinklepsch/tenzing/issues/60

gamecubate commented 8 years ago

Would love to update them but I am stuck trying to get boot to save compilation output to a js file. Something not clear on their side. If you leave this open, I will submit a PR once I've got the problem solved and further understanding of some key concepts.

j1mr10rd4n commented 8 years ago

The implicit target task has been deprecated but not removed yet. At the moment boot only skips the implicit call if BOOT_EMIT_TARGET=no has been set in boot.properties, either in the project root or in ~/.boot/boot.properties. See the boot FAQ for details.

In any case - #63 adds an explicit call to target and should fix this issue.

j1mr10rd4n commented 8 years ago

P.S. @gamecubate. If you haven't seen it yet - check out Mimmo Cosenza's excellent tutorial. It uses boot throughout and covers a lot of key concepts.

gamecubate commented 8 years ago

Oh but I hadn't seen that. Started reading. Perfect. Thanks for the nudge. :)

martinklepsch commented 8 years ago

@j1mr10rd4n a link to Mimmo's tutorial, especially the boot related bits might be a good addition to the readme. What do you think?

j1mr10rd4n commented 8 years ago

@martinklepsch Sounds good to me, it's a great tutorial. What about here as an entry point?