search

martinl / openpilot

Open source driving agent - Subaru fork
https://github.com/martinl/openpilot/wiki/
MIT License
70 stars 72 forks source link

Add Impreza 2020/2021 support (reduced torque) #48

Closed trailtacos closed 3 years ago

trailtacos commented 3 years ago

I choose to keep these as two separate CARs, as there is the possibility that they will need different tuning values. For the moment I've put both as the tune from @letsdudiss1. Both these cars are torque limited.

We have an fpv2 for the Impreza 2020, but only fpv1 for the 2021.

martinl commented 3 years ago

Thanks, I set up impreza-2020 branch based on this PR since the reduced torque limit also needs to be set in panda safety. Different car models are only needed if the required tuning is different. I took the tuning values for impreza-2020 branch from here: https://github.com/scullionw/openpilot/blob/master-ci-crosstrek-2020-sng/selfdrive/car/subaru/interface.py#L44 Please test and let me know how they work. Also, FPv1 produces false postives since most global platform models are very similar and thus cannot be upstreamed. FPv2 is way to go.

trailtacos commented 3 years ago

Sounds good - will update locally to try those tune values and will report back :)