search

martinl / openpilot

Open source driving agent - Subaru fork
https://github.com/martinl/openpilot/wiki/
MIT License
70 stars 72 forks source link

Added firmware version for my 2018 Crosstrek Limited to the #70

Closed budney closed 2 years ago

budney commented 2 years ago

This PR only adds the engine firmware version for my 2018 Crosstrek Limited; it's the only part of my car's fingerprint that wasn't already in car/subaru/values.py.

budney commented 2 years ago

I see a failed test report, but AFAICT it has nothing to do with this pull request. It's a compilation error in soundd somewhere.

budney commented 2 years ago

I also see a route replay error, but I'm not sure what to do to investigate further. Hard to imagine how a change to the subaru fingerprint list would have this effect, though. The VIN I noticed was for a Mazda, so it shouldn't even be exercising Subaru code.

martinl commented 2 years ago

Thanks for the PR. The added engine fw value is a duplicate of an existing value so I'll close it.

python has a few different encoding notations, so the following engine fw values are actually equal: b'\xaa!dt\a', b'\xaa!dt\x07',