martinl / openpilot

Open source driving agent - Subaru fork
https://github.com/martinl/openpilot/wiki/
MIT License
70 stars 70 forks source link

Cruise_Activated signals issues for Crosstrek Hybrid and Forester 2022 #94

Closed martinl closed 1 year ago

martinl commented 1 year ago

ES_DashStatus Cruise_Activated and ES_Brake Cruise_Activated signals have following issues when used on models that do not have CruiseControl Cruise_Activated signal:

1) stop behind lead car / hold - ES_DashStatus Cruise_Activated goes low on standstill 2) throttle pedal press - ES_DashStatus Cruise_Activated goes low on throttle pedal press 3) stop behind lead car / hold + disengage on brake pedal press - ES_Brake Cruise_Activated stays high after disengage

TODO

More info https://github.com/commaai/openpilot/pull/25378 https://github.com/commaai/openpilot/pull/26700

Which car does this affect?

Subaru Crosstrek Hybrid, Forester 2022

Provide a route where the issue occurs

7fd1e4f3a33c1673|2022-12-04--12-51-22

openpilot version

0.9.0

Additional info

No response

martinl commented 1 year ago

Crosstrek ICE ES_Status Cruise_Activated signal is identical to CruiseControl Cruise_Activated in all above cases Route: 8de015561e1ea4a0|2022-12-10--14-08-26

martinl commented 1 year ago

Forester 2022 ES_Status Cruise_Activated signal does not have issues with above cases Route: 7fd1e4f3a33c1673|2022-12-07--20-16-23

martinl commented 1 year ago

Crosstrek Hybrid does not have ES_Status message - need to find a route to analyze and find alternative signal for cruise state

martinl commented 1 year ago

closing this and opening a new issue for Crosstrek Hybrid