martinlackner / abcvoting

Python implementations of approval-based committee (multi-winner) voting rules
https://abcvoting.readthedocs.io/
MIT License
32 stars 16 forks source link

Fix wrong test_output skips and set mip to non verbose #40

Closed lumbric closed 3 years ago

lumbric commented 3 years ago

The Gurobi output in mip was probably caused by a bug. Now mip is set to non-verbose, so we can unskip more tests.

codecov-io commented 3 years ago

Codecov Report

Merging #40 (8a22f60) into master (3a2f384) will increase coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   84.06%   84.12%   +0.05%     
==========================================
  Files          41       41              
  Lines        2856     2853       -3     
  Branches      657      655       -2     
==========================================
- Hits         2401     2400       -1     
+ Misses        387      386       -1     
+ Partials       68       67       -1     
Impacted Files Coverage Δ
tests/test_abcrules.py 92.00% <ø> (+0.55%) :arrow_up:
abcvoting/abcrules_mip.py 81.53% <100.00%> (+0.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a2f384...8a22f60. Read the comment docs.